search

AvtechScientific / ASL

Advanced Simulation Library - hardware accelerated multiphysics simulation platform.
http://asl.org.il
GNU Affero General Public License v3.0
217 stars 55 forks source link

Source files without copyright information #5

Closed ghisvail closed 9 years ago

ghisvail commented 9 years ago

licensecheck -r . | grep "No copyright" ./src/pics/grids/2Dconcatination.tex: No copyright UNKNOWN

Please add a suitable copyright header to the source files listed above.

AvtechScientific commented 9 years ago

It's not really a source file - just a Latex file, i.e. a doc file. I don't think there is a need to put copyright header into docs (like README.md). Anyway this file is covered by the last paragraph here: https://github.com/AvtechScientific/ASL/blob/master/examples/input_data/Media_Files_LICENSE.md

What do you think?

ghisvail commented 9 years ago

Latex files are source files, and the pdf generated from them is a binary. A copyright header may not be appropriate for that type of file, granted. Still, this issue remains.

Anyway this file is covered by the last paragraph here: https://github.com/AvtechScientific/ASL/blob/master/examples/input_data/Media_Files_LICENSE.md

This is ambiguous though. This notice is titled "Media Files" but the .tex is, as you stated earlier, documentation. The wording could definitely be improved.

Alternatively, you may consider shipping an additional COPYRIGHT file at the root of the source tree, which clearly explicits what files is governed by which license project-wise. Then, you can get rid of license exception files like the one you linked above.