AvyAddons / BetterBags_Bound

Filters for BoE & BoA items in BetterBags.
MIT License
0 stars 1 forks source link

[BUG] Some WuE / BoE items in wrong categories #6

Closed strayge closed 3 hours ago

strayge commented 4 hours ago

Description

Somehow some items are in wrong categories.

In plugin settings BoE, WuE and BoA categories are enabled.

BetterBags v0.3.16

Addon Version

v1.8.0

World of Warcraft Flavor

Retail (The War Within)

Tested with only BetterBags_Bound

Lua Error

No response

Reproduction Steps

  1. Get items
  2. Open bag

Screenshots

WuE in BoA category

image

WuE in Chest category

image

BoE in Chest category

image
strayge commented 4 hours ago

Seems like addon search BoA / WuE text at 2-4 lines in tooltip and for last two items it is in line 5

strayge commented 4 hours ago

as for the first item looks like ITEM_ACCOUNTBOUND now translates as Warbound

so technically addon correctly sorted item in BoA, but maybe whole BoA should be retired,
as all BOA_STRINGS now contains warbound / warband keyword in it

lucasvienna commented 4 hours ago

Seems like addon search BoA / WuE text at 2-4 lines in tooltip and for last two items it is in line 5

Indeed, originally this was 2-6 back in the AdiBags days, but due to performance and Tooltip scanning requiring heaps of resources, I've reduced it. Gonna put it back up to 6 and see if the performance hit isn't too bad.

as for the first item looks like ITEM_ACCOUNTBOUND now translates as Warbound

Yes! And Warbound is the new Account Bound (stuff like Pet Charms and the Marks of Honor are now Warbound). You can always just disable it, but I don't think retiring it is the way to go here.

Another alternative would be an option to rename to "Warbound". I can make that if it's something you'd be interested in.

strayge commented 3 hours ago

Another alternative would be an option to rename to "Warbound".

Sounds good, not sure if it is really necessary. Also only applicable to retail, as classic do not have warbands.

Anyway thank for quick fix.