AwakeEchidna / wiiu-vc-extractor

Extracts Wii U Virtual Console roms from dumps created via DDD or dumped from the SNES Mini
GNU General Public License v3.0
66 stars 9 forks source link

[Request] Export file name Bug? #62

Open tarky17 opened 2 years ago

tarky17 commented 2 years ago

environment

I used wiiuvcextractor.exe to extract Pokemon Pinball Ruby & Sapphire. Then the following error occurred.

Simple log

F:\myDir\Documents\tmp\game_rip\WiiU-ROM-dumper\wiiuvcextractor>wiiuvcextractor.exe alldata.psb.m
============================================================================
Starting extraction of rom from alldata.psb.m...
============================================================================
PSB file detected!
Decompressing PSB file...
Decompression to alldata.psb.m.extract completed
Checking for PSB data file F:\myDir\Documents\tmp\game_rip\WiiU-ROM-dumper\wiiuvcextractor\alldata.bin...
Found rom subfile at abppj1.c19.m
    Offset: 33810432
    Length: 2583575
Decompressing rom...
Decompressing PSB file...
Decompression to F:\myDir\Documents\tmp\game_rip\WiiU-ROM-dumper\wiiuvcextractor\abppj1.c19.m.extract completed
Checking if this is a GBA VC title...
Checking F:\myDir\Documents\tmp\game_rip\WiiU-ROM-dumper\wiiuvcextractor\abppj1.c19.m.extract...
GBA Rom Detected!
GBA Rom Code: BPPJ
GBA Title: POKEPIN R/S
Writing to POKEPIN R/S.gba...
Unhandled exception. System.IO.DirectoryNotFoundException: Could not find a part of the path.
   at System.IO.FileSystem.MoveFile(String sourceFullPath, String destFullPath, Boolean overwrite)
   at System.IO.File.Move(String sourceFileName, String destFileName, Boolean overwrite)
   at WiiuVcExtractor.RomExtractors.GbaVcExtractor.ExtractRom()
   at WiiuVcExtractor.Program.Main(String[] args)

Guess

I guess as follows.

GBA Title: POKEPIN R / S
Writing to POKEPIN R / S.gba ...

This may be due to the / (backslash) between the R and the S. The file cannot be output because it is a character that cannot be used in the Windows file name. So it may be causing an Unhandled exception.

Suggestion of improvement method

If this guess is correct, for example, the unusable characters are automatically changed to _ (underscore). Or maybe it can be solved by allowing the output file name to be specified in the parameter. wiiuvcextractor.exe -n export-filename