search

AwesomeFoodCoops / odoo-production

GNU Affero General Public License v3.0
40 stars 66 forks source link

[coop_badge_reader addon] Preserve aspect-ratio of badge image #1078

Closed DavidBruant closed 3 years ago

DavidBruant commented 4 years ago

Hi :-)

I'm David, member of Superquinquin in Lille My picture is all spread in the coop_badge_reader screen Based on quick tests, it seems like object-fit: contain; fixes the problem

I'm new to the project, so i'm not familiar with the contribution process

I'm happy to improve this PR with guidance if it doesn't comply with current standards

nguyenminhchien commented 4 years ago

Hi David,

your pull request has not submitted yet! Are you still working on it?

DavidBruant commented 4 years ago

I consider the PR done, but i don't know the contribution process so i chose to keep the PR as draft until i received a response

Do you consider it ready for review?

DavidBruant commented 4 years ago

oh... i realize that neither the file i edited nor any of its parent directories, nor the repo have a licence https://github.com/AwesomeFoodCoops/odoo-production/issues/1079

Adding a licence is a solution. I can propose other solutions if adding a licence does not work

nguyenminhchien commented 3 years ago

Ok, from our side, your contribution has been tested, and ready to be merged. fyi, here is the process in general:

  1. We pull your contribution
  2. Test it and give feedback if need any adjustment
  3. Merge the request
DavidBruant commented 3 years ago

Sounds good to me There is still the licence problem pending i believe