search

AwesomePossum212 / nametag-plus

A performant and modular solution to Roblox's default nametag system that automatically supports titles, health bars, and more.
MIT License
6 stars 2 forks source link

Rewrite of the NametagPlus module #22

Closed Water261 closed 2 years ago

Water261 commented 3 years ago

This rewrites the module using some new Luau features, like typechecking. It changes the config[instanceName] to config.defaults[instanceName] and just tidies up the code a little.

Water261 commented 3 years ago

Can you squad and merge this PR as well, cleans up some of the commits that are purely bug fixes.

Water261 commented 3 years ago

Force Push was to fix the accidental leak of my details, forgot using $ automatically selects the environment variable.

Water261 commented 3 years ago

Closing since my code is sloppy right now, looked fine on VSCode but Studio is complaining.

AwesomePossum212 commented 3 years ago

Sorry for the late response! I'll take a look at this once you reopen it. Thanks for helping out!

Also, if you don't hear back from me within a few days, please message me on the DevForum to remind me!

Water261 commented 3 years ago

It's no problem, I need to get it properly working in Studio first.

Water261 commented 3 years ago

Alright, now it should work. The issue was that I forgot to assign the frame a parent and therefore it wouldn't show up and just caused errors.

Water261 commented 3 years ago

When merging, can you squash and merge so I don't litter the commit history.

Water261 commented 3 years ago

Uh yeah, I'm not the best when it comes to git. This was me rebasing stuff. So fun.

Water261 commented 3 years ago

This adds variadic support as well.

Water261 commented 3 years ago

Alrighty, everything is finished and ready to be merged.

changeTag is now a variadic function to identify what should be changed you set the Name property inside the props table to the object you want to change.

AwesomePossum212 commented 2 years ago

Thank you so much! I'll review and approve this ASAP (there are a lot of changes though, so it could take some time).

Water261 commented 2 years ago

Yeah I'll add it back, I initially removed it and VSCode didn't through any syntax errors.

Water261 commented 2 years ago

Alright, all problems have been fixed.