search

Awesomeplayer165 / PillboxView

A Pillbox Capsule-like informational view for iOS written in UIKit
MIT License
6 stars 2 forks source link

PIllView is never remove from the view hierarchy after being dismissed #25

Open martindufort opened 11 months ago

martindufort commented 11 months ago

When showing a PillView, the view is added to the vcView hierarchy. However when dismissing the PillView all internals elements are removed but the PillView is never removed from the hierarchy.

See these lines: https://github.com/Awesomeplayer165/PillboxView/blob/d5f7cbfed3e914bc051ca275ede3f9dfa7c367c1/Sources/PillboxView/PillView.swift#L258

https://github.com/Awesomeplayer165/PillboxView/blob/d5f7cbfed3e914bc051ca275ede3f9dfa7c367c1/Sources/PillboxView/PillView.swift#L171

https://github.com/Awesomeplayer165/PillboxView/blob/d5f7cbfed3e914bc051ca275ede3f9dfa7c367c1/Sources/PillboxView/PillView.swift#L326

https://github.com/Awesomeplayer165/PillboxView/blob/d5f7cbfed3e914bc051ca275ede3f9dfa7c367c1/Sources/PillboxView/PillView.swift#L333

Expected behavior The PillView should be removed from the vcView hierarchy after being dismissed

Awesomeplayer165 commented 11 months ago

Thanks for pointing this out. I'll look into this more later and get back to you.