search

Awesomeplayer165 / PillboxView

A Pillbox Capsule-like informational view for iOS written in UIKit
MIT License
6 stars 2 forks source link

Adding macOS Compatibility (via AppKit) #26

Open martindufort opened 11 months ago

martindufort commented 11 months ago

I have forked this repo in order to add macOS compatibility and add it to one of our project.

In order to do so, without a huge amount of #if os(macOS) layered everywhere, I decided to leverage the compatibility framework UXKit: https://github.com/ZeeZide/UXKit

Are you interested in a PR that would support macOS compatibility or you intend on keeping this compatible with iOS macCatalyst only.

This will also imply that your package will have a dependency on UXKit to be compiled without errors. Thanks

Awesomeplayer165 commented 11 months ago

I think it's fine to have that dependency as long as it builds on all platforms fine. Open!

martindufort commented 11 months ago

Excellent. I can also submit a fix for issue #25 which I have resolved. I'm also working on having the PillView always centered within the window to resolve issue #24

martindufort commented 11 months ago

Little update on this PR.

I'm waiting for https://github.com/ZeeZide/UXKit/pull/3 to be approved so I can submit my changes here (since there is now a dependency).

Not sure what the timeline is for the repo owner to action this. Will let you know how it goes...

UPDATED Decided to use the equivalent and simpler NSUI package to provide AppKit compatibility.

Awesomeplayer165 commented 11 months ago

No problem!