Awful / Awful.apk

Native Android client for the Something Awful forums
110 stars 67 forks source link

More informative network informations #350

Open baka-kaba opened 9 years ago

baka-kaba commented 9 years ago

There's a lot of complaints about the app 'doing that logout error except I'm not logged out' and the like, and the forums have been pretty spotty on the desktop recently too. I think Awful is taking the fall here!

From what I can tell, right now the only checking for a page/thread list/forum list request is by parsing the page for signs of errors (error messages and the like), otherwise you get a generic "Loading failed!" message. It might be a good idea to explicitly handle bad network status codes too, and throw an AwfulError based on those, so when the forums aren't or DNS isn't working or whatever people don't assume it's the logout issue

baka-kaba commented 9 years ago

I've got this at the moment in ActualRequest in AwfulRequest, handling Volley's network errors (as far as I know it throws them for anything but a 200 status):

-edit I did a pull request at #351 instead

It's really just for troubleshooting and getting an idea of what's happening, but it can be made more readable for the punters. It still might be a good idea to keep the status code in there though, even if it's just in the secondary text on the dialog, just in case something happens down the line

baka-kaba commented 9 years ago

Also we could probably do with a spinny thing on every page sync / load or whatever - sometimes you press something and you know it's happening in the background, but there's no sign anything's happening until the network response starts to come in with the blue progress bar. Slow forums mean you can sit there for a while and it looks like the app isn't working