Awful / Awful.app

Something Awful Forums browser for iOS
https://forums.somethingawful.com/showthread.php?threadid=3837546&perpage=40&noseen=1
136 stars 45 forks source link

Request - mark browsers besides Safari with their actual name under "Default Browser" config #1161

Open RooneyMcNibNug opened 1 year ago

RooneyMcNibNug commented 1 year ago

It would be nice to have Awful.app use the default browser configured by the user on iOS instead of opening links up with Safari.

Apple has allowed changing default browser since iOS 14 - I can't really speak to how easy (or not) this change would be to work out, but it would be a super nice enhancement imo.

If I'm using Firefox Focus or DuckDuckGo Browser it doesn't come up as an option in the settings:

image

Steps to reproduce

  1. Launch Awful.
  2. Click the settings gear
  3. Click "Default Browser"
  4. Regardless of if any other browsers are installed, you will only see options for "Awful" and "Safari"

Expected result

Other browsers installed on iOS will show as options

Observed result

I'm going on Safari

RooneyMcNibNug commented 1 year ago

Okay, so I want to amend this a bit - this is properly using the default browser when I select Safari, but the browser in question is not Safari.

Maybe this is simply a request to change the wording in the "Default Browser option" - where it is "Awful" and "Default iOS Browser" as the option, since it seems to be taking it from the system config?

dfsm commented 1 year ago

Hey, I've pushed a change to address this. Rewording "Safari" to "Default iOS Browser" was the simplest solution. Should be in the next beta!

RooneyMcNibNug commented 1 year ago

Awesome, thank you @dfsm!