Ax9D / pw-viz

Pipewire graph editor written in Rust. WIP⚠️
GNU General Public License v3.0
230 stars 14 forks source link

Miscellaneous formatting and style changes #8

Closed mkrasnitski closed 2 years ago

mkrasnitski commented 2 years ago

Sorry for the low-hanging fruit PR. Went through and cleaned up formatting and some small code layout issues. No major business logic changes. Moved Node, Link, and Port definitions into graph.rs after pruning some unnecessary methods (like field getters). Didn't touch the topological sort implementation.

mkrasnitski commented 2 years ago

Why was this closed?

Ax9D commented 2 years ago

I assumed undoing those changes was too much work to ask for, as I misinterpreted what "resolve" meant, I apologise for not understanding the intent, I'm still fairly new to (and learning) the semantics around Pull Requests on GitHub, I am reopening the PR, extremely sorry about the inconvenience.

mkrasnitski commented 2 years ago

No worries. Changes have already been undone, so should be good to merge.

Ax9D commented 2 years ago

Merged, thank you for your efforts! , and dealing with my ineptitude...