search

AxFoundation / strax

Stream analysis for xenon TPCs
BSD 3-Clause "New" or "Revised" License
27 stars 38 forks source link

Lone hit area #733

Open shenyangshi opened 1 year ago

shenyangshi commented 1 year ago

https://github.com/AxFoundation/strax/blob/afaf8cf6e468a87977eec8a6cb76812ada175437/strax/processing/peak_building.py#L482-L484

If we make the lone hits area also normalized according to PMT adc_to_pe like the peaklets instead of [ADC x samples], will it cause trouble elsewhere?

WenzDaniel commented 1 year ago

We would need to check where it is called. Would there be a big benefit changing it into pe?

shenyangshi commented 1 year ago

Thanks for the quick response @WenzDaniel! Since the gain model is a time-dependent correction, people interested in lone hits properties like area, DPE component or stability need to fetch the corrections themselves and correct run-by-run. I think it's nice if we can do this at the basement level.

shenyangshi commented 1 year ago

Maybe @a1exndr and @paloma can comment on the influence on the lone hit gain correction.

WenzDaniel commented 1 year ago

We can change it if needed. But this requires some careful checks and testing.