search

AxFoundation / strax

Stream analysis for xenon TPCs
BSD 3-Clause "New" or "Revised" License
27 stars 38 forks source link

Use parentheses to separate the class name and attributes in the representation of StorageFrontend #809

Closed dachengx closed 7 months ago

dachengx commented 7 months ago

What is the problem / what does the code in this PR do

Previously the representation of StorageFrontend was somehow confusing:

[straxen.storage.rundb.RunDB, readonly: True, strax.storage.files.DataDirectory, readonly: True, path: /dali/lgrandi/xenonnt/raw, take_only: ('raw_records', 'raw_records_he', 'raw_records_aqmon', 'raw_records_nv', 'raw_records_aqmon_nv', 'raw_records_aux_mv', 'raw_records_mv'), strax.storage.files.DataDirectory, readonly: True, path: /dali/lgrandi/xenonnt/processed, strax.storage.files.DataDirectory, readonly: True, path: /project2/lgrandi/xenonnt/processed]

This PR use the parentheses to separate the class name and its attributes:

[straxen.storage.rundb.RunDB (readonly: True), strax.storage.files.DataDirectory (readonly: True, path: /dali/lgrandi/xenonnt/raw, take_only: ('raw_records', 'raw_records_he', 'raw_records_aqmon', 'raw_records_nv', 'raw_records_aqmon_nv', 'raw_records_aux_mv', 'raw_records_mv')), strax.storage.files.DataDirectory (readonly: True, path: /dali/lgrandi/xenonnt/processed)]

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

github-actions[bot] commented 7 months ago

Coverage Status

coverage: 91.506% (+0.09%) from 91.42% when pulling 56a0e8151ab3054399b13d9e4eeb20a20f624101 on sf_repr into 55d82b03cd62cbf31b7fa5ea92d1ee0156277bd2 on master.

coveralls commented 7 months ago

Coverage Status

coverage: 91.47% (+0.05%) from 91.42% when pulling 56a0e8151ab3054399b13d9e4eeb20a20f624101 on sf_repr into 55d82b03cd62cbf31b7fa5ea92d1ee0156277bd2 on master.

yuema137 commented 7 months ago

@dachengx I checked that the representation of StorageFrontend is not used directly and is just a property to provide information. So the format change looks good to me.