AxFoundation / strax

Stream analysis for xenon TPCs
BSD 3-Clause "New" or "Revised" License
27 stars 38 forks source link

Do not call `get_components` in `is_stored` #813

Closed dachengx closed 6 months ago

dachengx commented 6 months ago

What is the problem / what does the code in this PR do

Further simplify https://github.com/AxFoundation/strax/pull/796. Because get_components will call the initialization of FileSaver, which will try to make and delete _temp folders.

See slack thread.

Can you briefly describe how it works?

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

coveralls commented 6 months ago

Coverage Status

coverage: 91.475% (-0.08%) from 91.557% when pulling 6d4223db640f6c2fd7d24aede2ab8334712f51d1 on no_default_detail_is_stored into 243eb2bc6b3b2a83d5180e98f90d4e45c45d231b on master.