Filter out duplicated targets in function `get_iter` - Githubissues

AxFoundation / strax

Stream analysis for xenon TPCs

BSD 3-Clause "New" or "Revised" License

27 stars 38 forks source link

Filter out duplicated targets in function `get_iter` #860

Closed dachengx closed 2 months ago

dachengx commented 2 months ago

What is the problem / what does the code in this PR do

Fix https://github.com/AxFoundation/strax/issues/846

The reason this can work is explained here: https://github.com/AxFoundation/strax/pull/859#issue-2432793166

Can you briefly describe how it works?

Remove duplicated targets when get_iter.

Can you give a minimal working example (or illustrate with a figure)?

Please include the following if applicable:

Update the docstring(s)
Update the documentation
Tests to check the (new) code is working as desired.
Does it solve one of the open issues on github?

Please make sure that all automated tests have passed before asking for a review (you can save the PR as a draft otherwise).

coveralls commented 2 months ago

coverage: 90.43% (+0.001%) from 90.429% when pulling 187970f0a5287886b38bf666ecafb2f375dad1e3 on unique_targets into 2218e78722cb64cdedb17e255752b7857c5f229b on master.