AxFoundation / strax

Stream analysis for xenon TPCs
BSD 3-Clause "New" or "Revised" License
27 stars 38 forks source link

Prohibit usage of `chunk_number` for special plugins like `OverlapWindowPlugin` #875

Closed dachengx closed 1 month ago

dachengx commented 1 month ago

chunk_number was introduced in https://github.com/AxFoundation/strax/pull/863. But if the per chunk storage and processing are used on plugins like OverlapWindowPlugin, the result might be wrong because the chunk boundary is not completely considered after per chunk storage isolates the chunks.

So we need to check the plugin used in per chunk storage. The check can be done at the same time when we solve https://github.com/AxFoundation/strax/issues/874.