AxaFrance / oidc-client

Light, Secure, Pure Javascript OIDC (Open ID Connect) Client. We provide also a REACT wrapper (compatible NextJS, etc.).
MIT License
571 stars 152 forks source link

Something changed while fetching userinfo between 2 versions. #1336

Closed bhargavmullakuru closed 2 months ago

bhargavmullakuru commented 3 months ago

Issue and Steps to Reproduce

Hi @guillaume-chervet , There is something changed between 7.14.1 and 7.21.0.

Before in 7.14.1 my userinfo fetch was working fine, authorization header going with Bearer xxxxx in header. Screenshot 2024-04-03 233927

In new version 7.21.0 i was getting 401 error while getting userinfo. there is something changed as it was going as PoP xxxxx in authorization header.

Screenshot 2024-04-03 233915

pls refer the Authorization header starting value in Attached screenshots. when i tried the failed request manually through postman with Authorization : Bearer xxxxxxx ... it was working fine.

seems like something got changed in recent versions.

Could you please look into it. Thanks in Advance

Versions

7.14.1 and 7.21.0

Screenshots

Expected

Actual

Additional Details

guillaume-chervet commented 3 months ago

Hi @bhargavmullakuru thnak you for your feedback again :)

Hi need to set up a configurable way to inject dpop or not to a domains or not. I do not know how yet :/ https://github.com/AxaFrance/oidc-client/blob/ef1597ea2c6d41e8d61b6a27bc26f6ad40304a50/packages/oidc-client/src/fetch.ts#L24

guillaume-chervet commented 3 months ago

I have just published version 7.22.0-alpha.1416 that should do the job @bhargavmullakuru .

bhargavmullakuru commented 3 months ago

Let me check it. Thanks @guillaume-chervet

bhargavmullakuru commented 2 months ago

It's working now. Pls let me know once it is released. i will update the version. Thanks @guillaume-chervet

bhargavmullakuru commented 2 months ago

is it merged to main and released @guillaume-chervet ?. so that we can close this issue. Thanks

guillaume-chervet commented 2 months ago

Hi @bhargavmullakuru , thank you for your feedback. I will try to merge it before the end of the week.

guillaume-chervet commented 2 months ago

I published version 7.22.0 @bhargavmullakuru . Thank you again.

bhargavmullakuru commented 2 months ago

Thanks @guillaume-chervet . closing this