HOTFIX: Unable to compile the library using TypeScript 3.8.3 - Githubissues

AxaFrance / oidc-client

Light, Secure, Pure Javascript OIDC (Open ID Connect) Client. We provide also a REACT wrapper (compatible NextJS, etc.).

MIT License

570 stars 152 forks source link

HOTFIX: Unable to compile the library using TypeScript 3.8.3 #1351

Closed ivan-pelyno closed 2 months ago

ivan-pelyno commented 2 months ago

Issue and Steps to Reproduce

I am unable to compile/build the library using TypeScript 3.8.3. Here are the steps I have taken:

Installed TypeScript 3.8.3
Tried to build

Versions

7.22.2

Screenshots

Expected

Make some minor changes in the following file @axa-fr/react-oidc/dist/index.d.ts

Instead of export { type OidcUserInfo, TokenRenewMode, OidcClient, TokenAutomaticRenewMode, OidcLocation } from '@axa-fr/oidc-client';
Modify the existing line to look like this export { TokenRenewMode, OidcClient, TokenAutomaticRenewMode, OidcLocation } from '@axa-fr/oidc-client'; export type { OidcUserInfo } from '@axa-fr/oidc-client';

Additional Details

Installed packages: "typescript": "3.8.3",

guillaume-chervet commented 2 months ago

Thank you @ivan-pelyno version 7.22.3 fixed it :)

ivan-pelyno commented 2 months ago

@guillaume-chervet Thank you so much for taking the time to fix the issue quickly !)

guillaume-chervet commented 2 months ago

May we close the issue @ivan-pelyno ?