Events `syncTokensAsync_begin`, `syncTokensAsync_end`, `syncTokensAsync_error` are never emitted - Githubissues

AxaFrance / oidc-client

Light, Secure, Pure Javascript OIDC (Open ID Connect) Client. We provide also a REACT wrapper (compatible NextJS, etc.).

MIT License

570 stars 152 forks source link

Events `syncTokensAsync_begin`, `syncTokensAsync_end`, `syncTokensAsync_error` are never emitted #1365

Open krzempekk opened 1 month ago

krzempekk commented 1 month ago

Issue and Steps to Reproduce

In event list (https://github.com/AxaFrance/oidc-client/blob/main/packages/oidc-client/src/events.ts) following events are declared:

syncTokensAsync_begin
syncTokensAsync_end
syncTokensAsync_error

However, looks like none of this three is ever actually emitted - there are no references in oidc-client code. Should those be cleaned up?

Versions

7.22.4

Expected

No events that are never emitted are present in eventNames list.

Actual

There are some event that are never emitted in eventNames list.

guillaume-chervet commented 1 month ago

Thank you @krzempekk for your issue. I will look at it as soon as i can. It should be triggered.