search

AxaFrance / oidc-client

Light, Secure, Pure Javascript OIDC (Open ID Connect) Client. We provide also a REACT wrapper (compatible NextJS, etc.).
MIT License
592 stars 160 forks source link

Increase tests cases coverage and introduce e2e tests #1424

Open darkowic opened 3 months ago

darkowic commented 3 months ago

Test automation is crucial for efficient and reliable delivery of a library. We've noticed that the test coverage of the oidc-client is pretty poor — only ~29% of statements are covered. We see that PRs must not necessarily must be provided with appropriate tests before they get merged and this decreases the credibility of the library. Also, there are no e2e tests and the maintainer runs the tests manually for more advanced cases.

I want to propose coming up with a plan on how to improve that matter. Have you ever thought about how to do this better?

jafin commented 3 months ago

PR's are always welcome. ❤️

guillaume-chervet commented 3 months ago

Hi @darkowic , It is really a good point. I am lacking of time. For now i never publish a version whithout testing it and i consume always the new version in my current web application. Help and PRs would be awesome.