search

AxaFrance / react-toolkit

Flexible components html + css + react using BEM convention. Maybe, you can call it "Design System" !
https://axafrance.github.io/design-system/
MIT License
97 stars 63 forks source link

[Bug]Pager #689

Closed LeGrandKhan closed 4 years ago

LeGrandKhan commented 4 years ago

Issue and Steps to Reproduce

Bug with pager on selected page with large amount of pages

Versions

1.3.21

Screenshots

image

Expected

Actual

Additional Details

gcruchon commented 4 years ago

Looks like I can't assign it to myself, but I think i found the fix. PR to come very soon.

gcruchon commented 4 years ago

PR will come as soon as I understand how to make sure my code works... however, documentation does not seem "up-to-date".

In CONTRIBUTING.md, as I changed a style file (pager.scss), it says that I should run npx gulp all, but gulp was removed 3 month ago (#651)

I understood that I should run npm run style instead... but it does seem not affect my storybook, even after I ran an npm run storybook:build. Any help would be appreciated and I'll update the CONTRIBUTING.md (and package.json) accordingly :-)

gcruchon commented 4 years ago

Did npm run cleanand then npm run postinstall. Not sure it's the way to go (maybe to many things were done), but it works. https://github.com/gcruchon/react-toolkit/commit/9cbe8f4d333f49fc27ba0e35ef5bcbb9ebb5ef34

gcruchon commented 4 years ago

This issue is fixed, @johnmeunier :)

gcruchon commented 4 years ago

BTW; I can't close this issue. Who is supposed to do it? ping @samuel-gomez-axa @youf-olivier @guillaumechervet cc @LeGrandKhan : you can test, I guess :)

samuel-gomez-axa commented 4 years ago

done : https://github.com/AxaGuilDEv/react-toolkit/pull/694