AxalotLDev / Async

Async is a Fabric mod designed to improve entity processing performance.
https://modrinth.com/mod/async
GNU General Public License v3.0
20 stars 3 forks source link

1.21.1 - Async mod breaks block breaking exploits (like bedrock breaking) #26

Closed TheRedXD closed 2 days ago

TheRedXD commented 6 days ago

Hello everyone, So I'm testing the async mod for version 1.21.1, async's version is 0.1.3+alpha.1-1.21.1 We've been testing it on an SMP server and so far the performance improvements are very real and extremely beneficial, however, this mod broke the ability to break bedrock using block breaking exploits.

The method we used uses a piston, not TNT. It's not the classic method a lot of people use nowadays. It uses packet alignment via disabling the currently used network quickly and re-enabling it - which makes the bedrock break practically every single time.

From the video my friend recorded, you will notice the bedrock breaks, except this only registers client-side - server-side, the bedrock does not break whatsoever.

We tried disabling async via the command, but oddly enough - that didn't fix the issue. However, we tested this on a server with the mod installed and without (as we suspected it's the potential issue), and it was clear that the mod was the issue.

It could be related to the moving block entity the piston summons apparently, as async, to my knowledge, exclusively handles entities.

https://github.com/user-attachments/assets/6eaa354f-420b-4126-8f5b-d92faf9419c0

FurryMileon commented 6 days ago

async-0.1.4+alpha.1-1.21.1 (8).zip Try this version of the mod.

Hello everyone, So I'm testing the async mod for version 1.21.1, async's version is 0.1.3+alpha.1-1.21.1 We've been testing it on an SMP server and so far the performance improvements are very real and extremely beneficial, however, this mod broke the ability to break bedrock using block breaking exploits.

The method we used uses a piston, not TNT. It's not the classic method a lot of people use nowadays. It uses packet alignment via disabling the currently used network quickly and re-enabling it - which makes the bedrock break practically every single time.

From the video my friend recorded, you will notice the bedrock breaks, except this only registers client-side - server-side, the bedrock does not break whatsoever.

We tried disabling async via the command, but oddly enough - that didn't fix the issue. However, we tested this on a server with the mod installed and without (as we suspected it's the potential issue), and it was clear that the mod was the issue.

It could be related to the moving block entity the piston summons apparently, as async, to my knowledge, exclusively handles entities.

2024-11-21_19-22-20.mov

TheRedXD commented 4 days ago

async-0.1.4+alpha.1-1.21.1 (8).zip Try this version of the mod.

Hello everyone, So I'm testing the async mod for version 1.21.1, async's version is 0.1.3+alpha.1-1.21.1 We've been testing it on an SMP server and so far the performance improvements are very real and extremely beneficial, however, this mod broke the ability to break bedrock using block breaking exploits. The method we used uses a piston, not TNT. It's not the classic method a lot of people use nowadays. It uses packet alignment via disabling the currently used network quickly and re-enabling it - which makes the bedrock break practically every single time. From the video my friend recorded, you will notice the bedrock breaks, except this only registers client-side - server-side, the bedrock does not break whatsoever. We tried disabling async via the command, but oddly enough - that didn't fix the issue. However, we tested this on a server with the mod installed and without (as we suspected it's the potential issue), and it was clear that the mod was the issue. It could be related to the moving block entity the piston summons apparently, as async, to my knowledge, exclusively handles entities. 2024-11-21_19-22-20.mov

Didn't seem to work.

Rozbiynk commented 3 days ago

lol just look down when you enable your internet that's all

TheRedXD commented 2 days ago

lol just look down when you enable your internet that's all

Says the guy who wastes time writing angry comments on the internet, while his nation proceeds to start a pointless war that only destroys the aggressor's economy even further

You aren't proving a single point kid. Quit the kool-aid.

AxalotLDev commented 2 days ago

This mod only works on the server side.

Rozbiynk commented 2 days ago

lol just look down when you enable your internet that's all

Says the guy who wastes time writing angry comments on the internet, while his nation proceeds to start a pointless war that only destroys the aggressor's economy even further

You aren't proving a single point kid. Quit the kool-aid.

erm, im recreate your situation and you literally need to look down. When you send packet it also consider your head orientation, so after you enable internet. I cant understand where are you see any angry. Just your issue don't related to mod but how use produce method

TheRedXD commented 2 days ago

lol just look down when you enable your internet that's all

Says the guy who wastes time writing angry comments on the internet, while his nation proceeds to start a pointless war that only destroys the aggressor's economy even further

You aren't proving a single point kid. Quit the kool-aid.

erm, im recreate your situation and you literally need to look down. When you send packet it also consider your head orientation, so after you enable internet. I cant understand where are you see any angry. Just your issue don't related to mod but how use produce method

Oh, this was a misunderstanding. Sorry about that. I expected an angry comment, because I deal with those everyday, and yours looked to me like an insult.

Probably a language barrier, what you said is very close to an insult that generally appears in various comment sections.

Thanks for the clarification, I will ask my friend about this.

So, to clarify once more, what you're asking for me to do is to move the player's head down right before re-enabling the internet connection, in order to position the piston? It's odd that this seemed to have not worked exactly in the scenarios that Async was enabled. Probably confirmation bias in that case.

Rozbiynk commented 2 days ago

I tested this thing with and without async, behaviour was same, probably without async you accidentally looked down, so piston get placed correctly. You can also use accurate block placement protocol (if enabled in carpet extra) with same names feature in tweakeroo