feat: deprecate `FormField.id` in favor of `databaseId` - Githubissues

AxeWP / wp-graphql-gravity-forms

GraphQL API for interacting with Gravity Forms.

GNU General Public License v3.0

165 stars 29 forks source link

feat: deprecate `FormField.id` in favor of `databaseId` #352

Closed justlevine closed 1 year ago

justlevine commented 1 year ago

What

Deprecates the FormField.id GraphQL field in favor of FormField.databaseId.

Why

In a future release, we need to change the id to be a Relay ID, so we can implement #298 and make the connection fully Relay compliant (see #335)

How

Testing Instructions

Additional Info

Checklist:

[x] This PR is tested to the best of my abilities.
[x] This PR follows the WordPress Coding Standards.
[x] This PR has proper inline documentation.
[x] This PR has unit tests to verify the code works as intended.
[ ] The changes in this PR have been noted in CHANGELOG.md

codeclimate[bot] commented 1 year ago

Code Climate has analyzed commit 1fed98c5 and detected 0 issues on this pull request.

The test coverage on the diff in this pull request is 100.0% (50% is the threshold).

This pull request will bring the total coverage in the repository to 84.3% (0.0% change).

View more on Code Climate.