fix: Don't overwrite existing `Access-Control-Expose-Headers` when adding `X-WPGraphQL-Login-Refresh-Token`.

AxeWP / wp-graphql-headless-login

A WordPress plugin that provides Headless login and authentication for WPGraphQL, supporting traditional passwords, OAuth2/OpenID Connect, JWT, and more.

GNU General Public License v3.0

66 stars 11 forks source link

fix: Don't overwrite existing `Access-Control-Expose-Headers` when adding `X-WPGraphQL-Login-Refresh-Token`. #37

Closed justlevine closed 1 year ago

justlevine commented 1 year ago

What

This PR fixes a bug where adding the X-WPGraphQL-Login-Refresh-Token to Access-Control-Expose-Headers would overwrite existing values.

Why

How

Testing Instructions

Additional Info

Checklist:

[x] My code is tested to the best of my abilities.
[x] My code follows the WordPress Coding Standards.
[x] My code has proper inline documentation.
[x] I have added unit tests to verify the code works as intended.
[x] I included the relevant changes in CHANGELOG.md

coveralls commented 1 year ago

Coverage: 61.685% (-0.07%) from 61.755% when pulling dd517cf8970a21ea4fc7960a1f62f44211dffa33 on justlevine:fix/keep-existing-expose-headers into 0095769e866f77388fb0e985f63f5a7869d11911 on AxeWP:develop.