AxeWP / wp-graphql-headless-login

A WordPress plugin that provides Headless login and authentication for WPGraphQL, supporting traditional passwords, OAuth2/OpenID Connect, JWT, and more.
GNU General Public License v3.0
72 stars 11 forks source link

fix!: use ProviderConfig::get_slug() for registry keys #57

Closed justlevine closed 1 year ago

justlevine commented 1 year ago

What

Changes the ProviderRegistery to use ProviderConfig::get_slug() for the provider class keys. This ensures the code will continue to work even if the slug of a ProviderConfig gets changed in the future.

Why

Fixes #56 (caused by the slug for OAuth2 Generic changing in v0.0.7)

How

Testing Instructions

Additional Info

Checklist:

coveralls commented 1 year ago

Coverage Status

Coverage: 83.741%. Remained the same when pulling cea2a38d28e9a2d326f04d4eea6900959d4ef8fe on justlevine:fix/provider-registry-keys into dbb2aba28a61d7aff6e75633cd486dee11eea3a6 on AxeWP:develop.

justlevine commented 1 year ago

Need to either find a way to avoid the type name change altogether or make the generated names more semantic before merging 🤔