AxeWP / wp-graphql-rank-math

Add GraphQL support for RankMath SEO
GNU General Public License v3.0
50 stars 7 forks source link

feat: expose additionalProfiles field to the social settings #75

Closed colis closed 5 months ago

colis commented 5 months ago

What

This PR exposes the additionalProfiles field to the social settings, i.e.

rankMathSettings {
    meta {
      social {
        facebookPageUrl
        twitterAuthorName
        additionalProfiles <----
      }
    }
  }

Why

The Rank Math plugin allows us to add other social profiles apart from the Facebook URLs and the Twitter username. Therefore this field needs to be added to the GraphQL schema.

How

Testing Instructions

  1. From the Rank Math Settings -> Titles & Meta -> Social Meta
  2. Add a single URL or a list of comma-separated URLs to the Additional Profiles field
  3. Use the query above in the GraphiQL IDE

Additional Info

Checklist:

colis commented 5 months ago

Thanks so much for this PR @colis 🙌

Do you think you would be able to add some unit tests for this? If not, no worries it just means it'l take a week or two before I can merge/trigger a release.

(I'm currently overseas on-location for a client and won't be able to dive in too deeply until I'm back.)

hey @justlevine, no worries 🙂

I've updated the existing unit tests, let me know if that's good enough.

Cheers