Closed colis closed 5 months ago
Code looks great - thanks @colis !
From a schema perspective, I'm wondering if we really want to introduce the
RankMathUserSocialMeta
interface vs making these fields directly available onRankMathUserSeo
.The latter would make the schema more robust to future changes (i.e. less likely for a change to necessitate something breaking), but I don't want a tech argument to win out if there's a practical use case I'm missing. 🤔
yep, that probably makes everything a bit easier 👍
(Note to self: schema should resolve directly to the Object type not to the interface type. having to do ... on RankMathUserSeo
when we're already at user.seo
is stupid. Tracking in #79 )
What
This PR maps the social meta fields of the User object to the
RankMathUserSeo
type, i.e.Why
The Rank Math plugin allows us to add user's Facebook URL, Twitter username and other profiles. Therefore this data needs to be mapped to the GraphQL schema.
How
Testing Instructions
Additional Info
Checklist: