search

Axect / Peroxide

Rust numeric library with R, MATLAB & Python syntax
https://crates.io/crates/peroxide
Apache License 2.0
509 stars 31 forks source link

Do not include legend box if there is no legend #58

Closed GComitini closed 5 months ago

GComitini commented 5 months ago

Currently, if a Plot2D is created and no legend is set, the plot still includes an empty legend box in the form of a small empty square placed at some corner of the image. This PR fixes this behavior, only drawing the legend if the legend vector is not empty.

Axect commented 5 months ago

Hello @GComitini ,

Thank you for your interest in the Peroxide project and for taking the time to submit this pull request. I appreciate your valuable contribution in fixing the empty legend box issue for Plot2D.

I have reviewed your changes, and they look great. The code effectively addresses the problem and will improve the user experience.

I have merged your pull request into the dev branch, and it will be included in the upcoming Peroxide release.

Once again, thank you for your contribution. We value the support and involvement of the community in making Peroxide better.

Best regards, Axect

Axect commented 5 months ago

Hello,

I published new version - v0.37.2 including your PR. Thank you again for contribution!

GComitini commented 5 months ago

Hello, thank you for the merge!