search

Axect / puruspe

PURe RUSt SPEcial library
Apache License 2.0
14 stars 6 forks source link

Fix cached besselik. Add tests of cached bessel functions. #24

Closed JSorngard closed 2 weeks ago

JSorngard commented 2 weeks ago

I added tests to the cached versions of the Bessel functions and discovered that my implementation of CachedBesselIK::besselik was wrong and fixed it.

It still required the user to pass in a mutable reference to a HashMap and hadn't been changed to take in a mutable reference to itself instead.

This PR completes the cached Bessel part of #12.

Axect commented 2 weeks ago

Thank you for the excellent modifications. I apologize for not catching this issue during the initial review process - it's something we should have spotted earlier.

I've confirmed that the implementation has been correctly updated. It's great to see that CachedBesselIK::besselik now takes a mutable reference to itself instead of requiring the user to pass in a mutable reference to a HashMap.

I'm particularly grateful for the addition of test code for CachedBessel. This will significantly enhance the reliability and stability of our codebase.

It's wonderful to see that this PR completes the cached Bessel portion of #12. Great work, and thanks again for your thorough attention to detail!