search

AxeldeRomblay / MLBox

MLBox is a powerful Automated Machine Learning python library.
https://mlbox.readthedocs.io/en/latest/
Other
1.49k stars 273 forks source link

a lot of cleaning and more pythonic style #20

Closed fmarmol closed 6 years ago

fmarmol commented 6 years ago

I think it's more readable and clean. Nothing else

codecov[bot] commented 6 years ago

Codecov Report

Merging #20 into master will not change coverage. The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #20   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           1      1           
  Lines           4      4           
=====================================
  Hits            4      4

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e740fb3...916c1bd. Read the comment docs.

maskani-moh commented 6 years ago

@fmarmol

Did you check pep8 screening results? (using flake or pep8 itself)

fmarmol commented 6 years ago

I fixed the last pep8 errors except the line too longs errors. The pep8 output is:

> pep8 na_encoder.py 
na_encoder.py:19:80: E501 line too long (85 > 79 characters)
na_encoder.py:26:80: E501 line too long (81 > 79 characters)
na_encoder.py:27:80: E501 line too long (97 > 79 characters)
na_encoder.py:28:80: E501 line too long (96 > 79 characters)
na_encoder.py:45:80: E501 line too long (169 > 79 characters)
na_encoder.py:59:80: E501 line too long (81 > 79 characters)
na_encoder.py:68:80: E501 line too long (106 > 79 characters)
na_encoder.py:69:80: E501 line too long (104 > 79 characters)
na_encoder.py:82:80: E501 line too long (99 > 79 characters)
na_encoder.py:99:80: E501 line too long (81 > 79 characters)
na_encoder.py:139:80: E501 line too long (127 > 79 characters)
na_encoder.py:140:80: E501 line too long (109 > 79 characters)
na_encoder.py:141:80: E501 line too long (111 > 79 characters)
na_encoder.py:142:80: E501 line too long (103 > 79 characters)
na_encoder.py:144:80: E501 line too long (86 > 79 characters)
na_encoder.py:145:80: E501 line too long (109 > 79 characters)
maskani-moh commented 6 years ago

@fmarmol

The problem is that the errorE051 is important in pep8 style as the readability of the code hugely depends on it (I think the most important one 😄). Usually line breaks are used when the line is too long and cannot be shortened.

For now, I guess you can let it like that.

Later we will integrate some pep8 checks in Travis to avoid these issues.