search

Axelrod-Python / axelrod-fortran

Python wrapper library around TourExec Fortran for Axelrod's second tournament.
Other
4 stars 0 forks source link

Random seeding #84

Closed marcharper closed 4 years ago

marcharper commented 4 years ago

Do not merge, won't work until the random_seed branch of Axelrod is merged

I don't understand what test_champion_v_alternator is doing.

drvinceknight commented 4 years ago

don't understand what test_champion_v_alternator is doing.

it's a specific regression test for https://github.com/Axelrod-Python/axelrod-fortran/issues/62 which was added in https://github.com/Axelrod-Python/axelrod-fortran/pull/63. It ensures this fix to TourExec works: https://github.com/Axelrod-Python/TourExec/pull/6/files

If I remember correctly there was an issue when k61r played repeatedly (which probably wasn't picked up in the original Axelrod tournaments as they were no repetitions so to speak).

EDIT: So I believe what it's doing is checking we get the same results when playing the match multiple times.

drvinceknight commented 4 years ago

EDIT: So I believe what it's doing is checking we get the same results when playing the match multiple times.

(But it's very poorly documented: that's my bad.)

marcharper commented 4 years ago

I believe I've fixed the test, which passes locally. But all the tests won't work here until we release a new version of axelrod.

drvinceknight commented 4 years ago

https://github.com/Axelrod-Python/Axelrod/pull/1288 has been merged: I plan to do a new release first thing tomorrow (Wednesday) morning.

drvinceknight commented 4 years ago

Looks good to me :+1: Once we have a new release I'll get the simulations going for the reproducing paper :+1:

marcharper commented 4 years ago

@meatballs PTAL. We should release a new version of axelrod-fortran after this PR goes in.

The CI checks don't show up for me on this page, you can see them passing here.

drvinceknight commented 4 years ago

The CI checks don't show up for me on this page, you can see them passing here.

Could be worth moving this to GitHub actions? I could have a go at putting that together.

marcharper commented 4 years ago

Sorry I hit request review from you @drvinceknight and cannot rescind it