Closed 0xJem closed 3 months ago
Some tests are failing:
claimBids()
on the mock batch auction module, which I was trying to avoid. (Otherwise why not just use the EMP module instead of a mock?)amountOutToClaim
value of 1. This may point to a rounding error. Superseded by #111
Fixes https://github.com/sherlock-audit/2024-03-axis-finance-judging/issues/187
Issue: the prefunding calc in
claimProceeds()
did not take into account whether the bids had been claimed. If bids were claimed beyond a certain threshold,routing.funding
would underflow.There were a few approaches that could be taken to solving this:
It seemed easier to track the bid payouts remaining.