search

Axis-Fi / axis-core

Axis Protocol
https://axis.finance
Other
3 stars 0 forks source link

Sherlock: Claim bids after claim proceeds #107

Closed 0xJem closed 3 months ago

0xJem commented 3 months ago

Fixes https://github.com/sherlock-audit/2024-03-axis-finance-judging/issues/67

Instead of adjusting the _revertIfNotSettled() virtual function, I decided that the "Claimed" auction status did not make sense, since the status is normally a mutually-exclusive state, which "Claimed" is not. That was also the cause of the problem!

0xJem commented 3 months ago

@Oighty do you agree about the reasoning for removing the "Claimed" status?

Also, are we sure that we want a "Decrypted" status, even though it doesn't apply to all auctions?

Oighty commented 3 months ago

The Status enum in generally is only for Batch Auctions. It would be good to move that to EMPAM solely along with the _revert functions that only apply to Batch Auctions, or to a Batch Auction abstract that can be inherited by future batch auctions. In general, this is an example of why splitting them is a good idea.

0xJem commented 3 months ago

The Status enum in generally is only for Batch Auctions. It would be good to move that to EMPAM solely along with the _revert functions that only apply to Batch Auctions, or to a Batch Auction abstract that can be inherited by future batch auctions. In general, this is an example of why splitting them is a good idea.

See https://github.com/Axis-Fi/moonraker/pull/118 (it merges into this, but I split it off in case we wanted to delay)

Oighty commented 3 months ago

Closing in preference of #139