search

Axis-Fi / axis-core

Axis Protocol
https://axis.finance
Other
3 stars 0 forks source link

Sherlock: WETH address incorrect #121

Closed 0xJem closed 2 months ago

0xJem commented 3 months ago

https://github.com/sherlock-audit/2024-03-axis-finance-judging/issues/73

The WETH address in the BlastAuctionHouse is for testnet, not mainnet

0xJem commented 3 months ago

@Oighty what I'm thinking for this:

Shift the _BLAST, _WETH and _USDB constants to immutable variables, and pass them through the constructor (and hence at deploy-time). This should enable us to give different values, based on the chain in use.

Oighty commented 3 months ago

That is there right approach. We did the current version bc of the bytecode limit. That shouldn't be an issue anymore with splitting the auction houses