Sherlock: Support bid refunds until the auction private key is submitted

Axis-Fi / axis-core

Axis Protocol

https://axis.finance

Other

3 stars 0 forks source link

Sherlock: Support bid refunds until the auction private key is submitted #123

Closed 0xJem closed 2 months ago

0xJem commented 3 months ago

Fixes https://github.com/sherlock-audit/2024-03-axis-finance-judging/issues/174

It also ensures that all of the top-level functions in the AuctionModule contract can be overriden (in order to change behaviour).

0xJem commented 3 months ago

@Oighty I'm unsure what the decision was regarding bid refunds, but I made the changes we discussed around letting bid refunds happen until private key submission

Oighty commented 3 months ago

@0xTex can you provide the requirements you had in mind for bid refunds post auction conclusion? We are currently allowing refunds at anytime until the private key is submitted to decrypt the auction.

0xTex commented 3 months ago

Ideally there would be a period of time after the auction concludes where bids cannot be cancelled. Then after the grace period for private key submission, enable bid cancellation again. This would prevent users front-running the private key submission to cancel their bid in cases of over-bidding.

0xJem commented 2 months ago

Superseded by https://github.com/Axis-Fi/moonraker/pull/143