search

Axis-Fi / axis-core

Axis Protocol
https://axis.finance
Other
3 stars 0 forks source link

Sherlock: totalIn overflow #125

Closed 0xJem closed 3 months ago

0xJem commented 3 months ago

Fixes https://github.com/sherlock-audit/2024-03-axis-finance-judging/issues/34

The Lot.purchased and Settlement.totalIn values can potentially overflow if stored as uint96, so they have been changed to uint256. This required a number of changes across the codebase.

0xJem commented 3 months ago

Need to shift AuctionHouse to use uint256 Auction modules can use uint96 (or whatever) at will

Oighty commented 3 months ago

I'd like to subsume this with #130