Sherlock [6]: Fix claim bids after claim proceeds

Axis-Fi / axis-core

Axis Protocol

https://axis.finance

Other

3 stars 0 forks source link

Sherlock [6]: Fix claim bids after claim proceeds #139

Closed Oighty closed 2 months ago

Oighty commented 2 months ago

Porting over @0xJem's fix to a new branch.

Fixes https://github.com/sherlock-audit/2024-03-axis-finance-judging/issues/67

Instead of adjusting the _revertIfNotSettled() virtual function, I decided that the "Claimed" auction status did not make sense, since the status is normally a mutually-exclusive state, which "Claimed" is not. That was also the cause of the problem!

0xJem commented 2 months ago

I'm receiving a MemoryLimitOOG error on the test_largeNumberOfFilledBids_optimalDecryption_gasUsage test in this branch... does not appear in GH checks though.