Axis-Fi / axis-core

Axis Protocol
https://axis.finance
Other
3 stars 0 forks source link

Sherlock [16]: Fixes inconsistent price math between EMPAM and queue #146

Closed Oighty closed 2 months ago

Oighty commented 2 months ago

Fixes https://github.com/sherlock-audit/2024-03-axis-finance-judging/issues/83

It is still possible to have some rounding imprecision with bid prices which can cause bids with larger IDs and technically higher prices to not get filled in preference of slightly lower (rounding error amount lower) bids. However, the queue treats the bids the same way as the auction logic. Therefore, the behavior will be consistent and no extra bids will be able to claim payouts and the total paid out should be accurate.