Closed Oighty closed 5 months ago
Suggestion: IBatchAuctionHouse.settle() should return whether settlement has finished or not.
function settle(
uint96 lotId_,
uint256 num_,
bytes calldata callbackData_
) external returns (uint256 totalIn, uint256 totalOut, bool finished, bytes memory auctionOutput);
Otherwise, the caller needs to monitor for the event or call the auction module to get the status.
Suggestion: IBatchAuctionHouse.settle() should return whether settlement has finished or not.
function settle( uint96 lotId_, uint256 num_, bytes calldata callbackData_ ) external returns (uint256 totalIn, uint256 totalOut, bool finished, bytes memory auctionOutput);
Otherwise, the caller needs to monitor for the event or call the auction module to get the status.
Added
Implements #169 . Work in Progress.
Tasks