Closed Oighty closed 1 month ago
Review also included PR 181, which included changes to allow bidding / purchasing "on behalf of" another address. This enables various integrations, such as "zaps" or other smart contracts that perform logic before the call.
Reviewed #174 and #181 Except a rounding issue (fixed by #182), everything looks good to me
Contracts with logic changes:
Changes made to contract logic:
auctionOutput
with seller provided parameters to determine derivative inputs.minBidSize
to be an amount of quote tokens, instead of a percent of capacity (which is in base tokens).settle
andclaimProceeds
functions on batch auctions to avoid situations where users receive tokens before the seller gets their proceeds (and can do something with them via the callback). Downstream change is thatonClaimProceeds
callbacks are nowonSettle
callbacks.abort
function that can be called after a batch auction concludes and its dedicated settle period has ended if the auction has not been settled. The purpose of this is for anyone to be able to abort an auction that cannot be settled so that the seller and bidders all receive refunds.Known risks (which we are ok with)
settle
can be blocked by a blacklisted seller / callback contract on the quote token or a reverting callback.dedicatedSettlePeriod
has passed.minBidSize
. In practice, this isn't likely to happen unlessminPrice
andminBidSize
are set poorly.