search

Axis-Fi / axis-core

Axis Protocol
https://axis.finance
Other
3 stars 0 forks source link

Allocated Allowlist + Improvements #199

Closed Oighty closed 4 weeks ago

Oighty commented 1 month ago

This PR implements a general version of the Allocated Allowlist implemented in the Baseline V2 repo, as specified in #198 . Various changes have been made for cleanliness and efficiency. Additionally, it makes some updates to the existing MerkleAllowlist contract, including adding a setter function where the lot's seller can update the root of the tree.

The AllocatedAllowlist callback inherits from the base MerkleAllowlist for minimal additional code.

0xJem commented 1 month ago

Looks fine. I made some changes to PR #200 that complement this - will need to merge those in.

0xJem commented 1 month ago

Tests will fail, but those will be fixed once PR 200 is merged in

Oighty commented 1 month ago

I think we're good here. I'm going to deploy updated testnet contracts so we can test with the OZ merkle library. Going to wait to merge until the security review is done on #193