Rounding errors could cause auctions to send out too many tokens (and create issues for the last to claim) or not receive enough payment. We need to review any math that involves token amounts to ensure the rounding behavior is desirable from the protocol perspective. We have done this more formally in the past. For example, Section 4 of https://github.com/Bond-Protocol/research/blob/master/papers/Sequential_Dutch_Auction_Markets.pdf reviewed the rounding behavior of each function in the original Bond Protocol SDA contract.
0xJem
commented
5 months ago
Rounding errors could cause auctions to send out too many tokens (and create issues for the last to claim) or not receive enough payment. We need to review any math that involves token amounts to ensure the rounding behavior is desirable from the protocol perspective. We have done this more formally in the past. For example, Section 4 of https://github.com/Bond-Protocol/research/blob/master/papers/Sequential_Dutch_Auction_Markets.pdf reviewed the rounding behavior of each function in the original Bond Protocol SDA contract.