Closed 0xJem closed 4 months ago
The implementation looks good. I'm a bit torn on not allowing prefunding for Atomic Auctions. Technically, you could prefund them and it would reduce gas costs on purchases a bit + allow sellers to deposit tokens instead of having them withdrawn from their wallet. However, having batch always require prefunding and it be optional for atomic seems like it could add some complexity.
The prefundingRequired
return value from the auction module offers a way to override the default. I can add it back?
allow sellers to deposit tokens instead of having them withdrawn from their wallet
It's more withdrawing tokens in one go vs every time there's a purchase, no?
Superseded by #73
auctionType()
function withAtomic
andBatch
as the enum values