AxisCommunications / backstage-plugins

Backstage Plugins Created by Axis Communications
MIT License
32 stars 17 forks source link

Add moment dependency to vacation-calendar plugin #153

Closed fridajac closed 4 months ago

fridajac commented 4 months ago

Hey, I just made a Pull Request!

Dependency moment has been added to the package.json of the vacation-calendar plugin.

Context

moment is a peer dependency to react-calendar-timeline, and without it the following error is displayed in any repo that is trying to install axis-backstage/vacation-calendar-plugin: Module not found: Can't resolve 'moment' in '/axis-backstage/node_modules/react-calendar-timeline/lib/lib/items' node_modules/react-calendar-timeline/lib/lib/items/Item.js. Adding the dependency should fix this error.

Checklist before requesting a review

changeset-bot[bot] commented 4 months ago

🦋 Changeset detected

Latest commit: 891c164e385708379c8785dc077a76f76e3157c5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ---------------------------------------- | ----- | | @axis-backstage/plugin-vacation-calendar | Patch | | app | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR