AxisCommunications / backstage-plugins

Backstage Plugins Created by Axis Communications
MIT License
32 stars 17 forks source link

support new frontend system within jira plugin #156

Closed alex-mckay closed 3 months ago

alex-mckay commented 3 months ago

Hey, I just made a Pull Request!

This PR adds support for the new frontend system to the jira plugin by exposing the entity content & API as extensions under the '/alpha' subpath. This change is fully back-compatible & has no affect on consumers who are still using the standard frontend system.

One small frontend change is in the case where the relevant annotation is missing, the JiraDashboardContent React element will now render the missing annotation screen instead of the error boundary. This is to facilitate a better frontend experience in the new frontend system, where the tab's appearance cannot (yet) be conditional on annotation values. It will be a no-op if one is using the old frontend and couched EntityJiraDashboardContent inside an if block with isJiraDashboardAvailable per the documentation.

Screenshot 2024-08-08 at 8 10 25 PM => Screenshot 2024-08-08 at 8 09 18 PM

If the request to itself jira-backend fails, there's no change in behavior.

Context

Spotify will be updating OSS plugins to the new frontend & backend as we work towards an updated Backstage plugin framework. We're prioritizing some community favorites first, and the Spotify team will help manage any unintentional issues that arise!

Issue ticket number and link

Checklist before requesting a review

changeset-bot[bot] commented 3 months ago

🦋 Changeset detected

Latest commit: 0d3aa8940495e725abf1058975099cf44f7eeacd

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | ------------------------------------- | ----- | | @axis-backstage/plugin-jira-dashboard | Minor | | app | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

alex-mckay commented 3 months ago

Hi @fridajac - would appreciate a review/any feedback here whenever you have time!