AxisCommunications / backstage-plugins

Backstage Plugins Created by Axis Communications
MIT License
32 stars 17 forks source link

Fixed caching of user issues when having multiple Jira issues #204

Closed grantila closed 3 weeks ago

grantila commented 3 weeks ago

Multi-instance fix for user issues

After #202, I found that the user issues view produced a little weird result (which obviously passed me by before). The cache key used in those queries are identical for ever Jira instance, so the cache will be filled with one of them, overwriting the other.

This PR fixes this by prepending the instance url to the cache key, so they become unique for every [user+instance].

Checklist before requesting a review

changeset-bot[bot] commented 3 weeks ago

🦋 Changeset detected

Latest commit: b5b74e362b18afe129a8af3cd610262f54430ed5

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages | Name | Type | | --------------------------------------------- | ----- | | @axis-backstage/plugin-jira-dashboard-backend | Patch | | backend | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

anicke commented 3 weeks ago

Thanks!

grantila commented 2 weeks ago

No worries @anicke! Could you trigger a release of this? 🙏

anicke commented 2 weeks ago

Done!