AxisCommunications / locomote-video-player

Media Player in Adobe Flash with RTSP support. (THIS PROJECT IS NO LONGER MAINTAINED)
BSD 3-Clause "New" or "Revised" License
133 stars 79 forks source link

chaining for on and off methods in js lib #125

Closed kreopt closed 9 years ago

kreopt commented 9 years ago

It's very convenient and cleaner to chain player events like this: player.on(evt1,cb1).on(evt2,cb2). So another little patch included.

kreopt commented 9 years ago

second commit avoids the situation when players attached to DOM container by specifying node overwrite each other cause string representation of HTMLElement is [object Object]. I'd change this behaviour to get container id to resolve player name.

noseglid commented 9 years ago

It would be nice to have these split into separate PRs.

Also, you must fix the build error (the code style does not follow the project guidelines)

kreopt commented 9 years ago

done

noseglid commented 9 years ago

Thanks for this! :+1: