search

AxisCommunications / locomote-video-player

Media Player in Adobe Flash with RTSP support. (THIS PROJECT IS NO LONGER MAINTAINED)
BSD 3-Clause "New" or "Revised" License
133 stars 79 forks source link

Fix parameters parsing problem in RTSPClient with Vivotek cameras #128

Closed defragmentator closed 9 years ago

defragmentator commented 9 years ago

Some cameras like Vivotek send parameters unicast and interleaved in different order. It causes problem in RTSPClient STATE_SETUP. Trying to fit this found another error with debugLogger. When set this flag from javascript with locomote.config( { "debugLogger": true } ); it changes Player::config.debugLogger , but com/axis/Logger is checking Player::debugLogger which is hardcoded. I've fixed this also.

noseglid commented 9 years ago

Thanks for fixing this! I've added a minor comment. Fix that and I'd be happy to merge this.

defragmentator commented 9 years ago

All requested changes has been made

noseglid commented 9 years ago

Thank you so much for addressing this!

The indentation in the diff is with tabs, but rest of the project uses 2 spaces. If it is all right with you, I can just merge this and resolve it with another commit.

defragmentator commented 9 years ago

Sorry for a mess with commit reverting, but now code should be ready to a merge.

noseglid commented 9 years ago

Looks great. Once again, thanks for fixing this!