search

AxisCommunications / onnx-to-keras

Convert onnx models exported from pytorch to tensorflow keras models with focus on performace and highleve compatibility.
MIT License
25 stars 13 forks source link

Fix op_add with constant #27

Open xsacha opened 3 years ago

xsacha commented 3 years ago

Fixes #26

hakanardo commented 3 years ago

Please consider adding a test aswell.

hakanardo commented 3 years ago

This could break things as constants might appear in other ops than add. How about keeping the old solution but add an inefficiency warning to it and then we can fix the ops one by one as needed?

xsacha commented 2 years ago

Sorry, I'm unsure about what you mean there. Without this change, the model won't load at all. For the OnnxConstant, is there an example that fails when b has no size? I can't think of an example for that test.

xsacha commented 2 years ago

Any update on this? Is there a corner case I need to test? Is there an alternative fix for #26?

Thanks