search

AxonFramework / extension-multitenancy

Axon Framework extension providing handles to support multi tenancy with distinct buses and stores per tenant.
Apache License 2.0
10 stars 2 forks source link

Multi tenant dead letter queue #108

Closed schananas closed 1 year ago

schananas commented 1 year ago

Implementation of multi tenant dead letter queue. Solves #94

schananas commented 1 year ago

@smcvb this ticket is now ready for review

schananas commented 1 year ago

First off, thanks for the effort here, @schananas! Shaping up nicely as it is and you've found some clear solutions to not impose constraints on the user with new APIs, but still provide a multi-tenant experience for the DLQ.

However, I've got quite a number of comments here. Largely JavaDoc, but also a couple conceptual pointers. Let's discuss and/or resolve them before we head on into merging this nice addition.

Hi @smcvb , all issues have been addressed

sonarcloud[bot] commented 1 year ago

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 13 Code Smells

2.4% 2.4% Coverage
0.0% 0.0% Duplication

smcvb commented 1 year ago

@schananas, it looks like the JDK8, JDK11, and JDK17 build failed for this PR. Would you mind checking if it breaks main and if it does, fix the predicaments?