search

Axosoft / glo-atom

Glo plugin for Atom
https://www.gitkraken.com/glo
MIT License
7 stars 5 forks source link

Cannot sign into Github #5

Open JJW8071 opened 5 years ago

JJW8071 commented 5 years ago

Windows 10 + Atom1.34.0 x64

Glo board signs in with Gitkraken account --> yes.

Settings > Integrations > Connect to Github --> Does nothing. Floating board banner: "This board is View-only because you are no longer connected to GitHub. Connect to GitHub to make changes" > Connect to Github --> Does nothing.

jdgarcia commented 5 years ago

We can't reproduce this on Atom 1.34.0 on either Windows 10 or macOS.

Does it work if try it in your browser?

Also, can you do the following:

  1. Open Glo in Atom
  2. Open the Atom dev tools (View > Developer > Toggle Developer Tools)
  3. Run this in the Atom dev tools console: $('webview').openDevTools() (this will open another dev tools for Glo)
  4. Click on Connect to GitHub

Does an error message show up in the console?

JJW8071 commented 5 years ago

image

Uncaught TypeError: $ is not a function at :1:1

JJW8071 commented 5 years ago

Ok, so I removed the atom browser-plus plugin (246,360 users), and I also updated to the Atom beta.

One of those two things have now enabled Glo Connect to Github to popout of Atom and auth in Chrome.

jdgarcia commented 5 years ago

I just installed the package you mentioned and it still works, so I'm thinking it was probably the Atom update, but I'm using the non-beta version and it works for me.

Though the fact that your Atom didn't have the $ function is also weird.